Make path separator escape configurable (#373)#611
Open
dbazile wants to merge 1 commit intopython-lsp:developfrom
Open
Make path separator escape configurable (#373)#611dbazile wants to merge 1 commit intopython-lsp:developfrom
dbazile wants to merge 1 commit intopython-lsp:developfrom
Conversation
Member
|
Hey @dbazile, I don't think this is the correct approach. If your client supports code snippets, the escapes added to paths by this server need to be handled by it, not by an additional option here. That's what we do in Spyder, at least:
|
Author
|
Funny thing about that. The client project (LSP-pylsp) said it’s a server issue. I literally got bounced here from two closed GH issues I raised over there. :)
…On Fri, Feb 7, 2025, at 17:23, Carlos Cordoba wrote:
Hey @dbazile <https://github.com/dbazile>, I don't think this is the correct approach. If your client supports code snippets, the escapes added to paths by this server need to be handled by it, not by an additional option here.
That's what we do in Spyder, at least:
dir-completions.gif (view on web) <https://github.com/user-attachments/assets/b9336f94-5f3c-4b0e-a4db-bad4d5868eb2>
—
Reply to this email directly, view it on GitHub <#611 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALYTA24NRTG2BODIULIIHT2OU56DAVCNFSM6AAAAABVBMEUWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBUGMYTAOBZGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Ok, then why don't you disable code snippets? That would avoid the path separator escaping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an opt-out for the forced path separator escaping added for #373. This fixes an issue where paths are always escaped, making this feature unusable without constant backtracking to remove escapes (see sublimelsp/LSP-pylsp#180).
I don't know how valid the default listed in CONFIGURATION.md is (the default value is whether or not snippets are supported, which always seems to be
true) but I can't figure out how better to phrase it.Demo
demo-fix.webm
References